kennknowles commented on code in PR #34307:
URL: https://github.com/apache/beam/pull/34307#discussion_r2021633152
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowMetrics.java:
##########
@@ -225,6 +230,40 @@ private DistributionResult
getDistributionValue(MetricUpdate metricUpdate) {
return DistributionResult.create(sum, count, min, max);
}
+ private GaugeResult getGaugeValue(MetricUpdate metricUpdate) {
+ if (metricUpdate.getGauge() == null) {
+ return GaugeResult.empty();
+ }
+ Object gaugeValue = metricUpdate.getGauge();
Review Comment:
It has been a while since I thought about gauge metrics. I know that
@Naireen worked on them some time. I am not sure what the spec here is, since
the protobuf is so generic. I am trying to find a design doc for a reference
but maybe @Naireen can tell us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
