damccorm commented on code in PR #34584:
URL: https://github.com/apache/beam/pull/34584#discussion_r2035400774
##########
.github/workflows/run_rc_validation_go_wordcount.yml:
##########
@@ -55,7 +56,10 @@ jobs:
- name: Fetch Go SDK RC and Tidy Modules
working-directory: ./sdks/go/examples/wordcount
run: |
- go get -d github.com/apache/beam/sdks/v2@${{
github.event.inputs.rc_tag }}
+ mkdir -p beam-test
+ cd beam-test
+ go mod init beam-test
+ go get github.com/apache/beam/sdks/v2/go/pkg/beam@${{
github.event.inputs.rc_tag }}
Review Comment:
I'm confused - what is this job actually doing?
It seems like we're getting the rc go package? But that will not live beyond
the duration of this particular job. Should this be part of the prism job so
that we use that version of the sdk?
##########
.github/workflows/run_rc_validation_go_wordcount.yml:
##########
@@ -83,9 +87,7 @@ jobs:
go run wordcount.go \
--input ./kinglear.txt \
--output ./output_prism.txt \
- --runner=PrismRunner \
- --environment_type=DOCKER \
- --environment_config=apache/beam_go_sdk:${{
github.event.inputs.container_tag }}
+ --runner=PrismRunner
Review Comment:
As this is currently written, it will not do anything with the rc version of
the sdk - we're not downloading beam anywhere.
##########
.github/workflows/run_rc_validation_go_wordcount.yml:
##########
@@ -83,9 +87,7 @@ jobs:
go run wordcount.go \
--input ./kinglear.txt \
--output ./output_prism.txt \
- --runner=PrismRunner \
- --environment_type=DOCKER \
- --environment_config=apache/beam_go_sdk:${{
github.event.inputs.container_tag }}
+ --runner=PrismRunner
Review Comment:
If you look at
https://github.com/apache/beam/actions/runs/14346450686/job/40217141111 you can
see it is using 2.65.0-dev
##########
.github/workflows/run_rc_validation_go_wordcount.yml:
##########
@@ -129,6 +131,7 @@ jobs:
--project=${{ env.GCP_PROJECT_ID }} \
--region=${{ env.GCP_REGION }} \
--temp_location=${{ env.GCS_TEMP_LOCATION }} \
+ --staging_location=${{ env.GCS_STAGING_LOCATION }} \
Review Comment:
Similarly, this does not submit the job with an rc version of Beam Go, it
just uses the RC container.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
