damccorm commented on code in PR #34601:
URL: https://github.com/apache/beam/pull/34601#discussion_r2037809936
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java:
##########
@@ -218,13 +218,7 @@ static SpannerOptions buildSpannerOptions(SpannerConfig
spannerConfig) {
if (serviceFactory != null) {
builder.setServiceFactory(serviceFactory);
}
- ValueProvider<String> host = spannerConfig.getHost();
- if (host != null) {
- String hostValue = host.get();
- if (hostValue != null && !hostValue.trim().isEmpty()) {
- builder.setHost(host.get());
- }
- }
+ builder.setHost(spannerConfig.getHostValue());
Review Comment:
If we don't set this at all (current behavior), what happens? Noting that
this is a silent behavior change for users who passed in null here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
