damccorm commented on code in PR #34411: URL: https://github.com/apache/beam/pull/34411#discussion_r2039885753
########## sdks/python/apache_beam/yaml/standard_io.yaml: ########## @@ -22,6 +22,30 @@ # should be kept in sync. # TODO(yaml): See if this can be enforced programmatically. +# BeamJar Providers +- type: beamJar + transforms: + 'WriteToCsv': 'beam:schematransform:org.apache.beam:csv_write:v1' + 'WriteToJson': 'beam:schematransform:org.apache.beam:json_write:v1' + config: + gradle_target: 'sdks:java:extensions:schemaio-expansion-service:shadowJar' Review Comment: My theory is that this broke the unit tests - if there are no other factors at play, we will eventually use the first provider that appears in this file (https://github.com/apache/beam/blob/ccba2e3a90fb5fc746f1f8752f9e614ebec357bc/sdks/python/apache_beam/yaml/yaml_transform.py#L319) The broken test seems to assume that the python provider will be used. Probably we should eventually fix this, but for now it might make sense to inline all python providers ahead of any java providers (and add a comment explaining why) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
