damccorm commented on PR #34526: URL: https://github.com/apache/beam/pull/34526#issuecomment-2797539324
> > I think this is actually not right. When we create the tag, we create a separate commit which is not on any branch, so it shouldn't point to a commit on the master branch > > It is a "lightweight" tag (not "annotated" tag) so it won't create a commit. It points to a commit on the master branch (the commit write before bumping version number) > > checked git log on master contains the following commits: > > ``` > commit a5281ddec07cbb468bfc3b656f2ee0e7652fe799 > Author: Danny McCormick <dannymccorm...@google.com> > Date: Fri Mar 21 11:07:11 2025 -0400 > > Perform correct release version validation (#34378) > > commit 76dfe7807c13b8f30029310cab25cc64bd683947 > Author: liferoad <actions@GitHub Actions 312.local> > Date: Fri Mar 21 13:20:40 2025 +0000 > > Moving to 2.65.0-SNAPSHOT on master branch. > > commit 24c230510be8b5e400021e8325ea654481c13698 (tag: v2.64.0-RC00) > Author: liferoad <huxiangq...@gmail.com> > Date: Fri Mar 21 09:16:23 2025 -0400 > > Fix version on the master (#34371) > > * fix the check > > * minor fix > ``` Oh, I see - I was thinking about https://github.com/apache/beam/tree/v2.64.0-RC1, not https://github.com/apache/beam/tree/v2.64.0-RC00 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
