shunping commented on code in PR #34623:
URL: https://github.com/apache/beam/pull/34623#discussion_r2043325938
##########
sdks/python/apache_beam/runners/portability/prism_runner.py:
##########
@@ -66,7 +69,12 @@ def default_environment(
return super().default_environment(options)
def default_job_server(self, options):
- return job_server.StopOnExitJobServer(PrismJobServer(options))
+ debug_options = options.view_as(pipeline_options.DebugOptions)
+ get_job_server = lambda: job_server.StopOnExitJobServer(
+ PrismJobServer(options))
+ if debug_options.lookup_experiment("enable_prism_server_singleton"):
Review Comment:
We decided to make it an experiment for the coming release 2.65.0
(https://github.com/apache/beam/issues/33623#issuecomment-2801641961), so we
don't introduce breaking change 2 weeks before branch cut and have more time to
bake in.
After we make prism runner as the default local runner, we can probably
choose to make singleton the default as well, but this will be upon further
discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
