derrickaw commented on code in PR #34654:
URL: https://github.com/apache/beam/pull/34654#discussion_r2049612752


##########
sdks/python/apache_beam/yaml/yaml_mapping.py:
##########
@@ -542,7 +542,6 @@ class _Explode(beam.PTransform):
           `cross_product` is set to `true` but only the two rows
           `('a', 1)` and `('b', 2)` when it is set to `false`.
           Only meaningful (and required) if multiple rows are specified.
-      error_handling: Whether and how to handle errors during iteration.

Review Comment:
   I reverted the error_handling doc string deletion and made another TODO to 
investigate further in conjunction with the other todo.  



##########
sdks/python/apache_beam/yaml/yaml_mapping.py:
##########
@@ -542,7 +542,6 @@ class _Explode(beam.PTransform):
           `cross_product` is set to `true` but only the two rows
           `('a', 1)` and `('b', 2)` when it is set to `false`.
           Only meaningful (and required) if multiple rows are specified.
-      error_handling: Whether and how to handle errors during iteration.

Review Comment:
   I reverted the error_handling doc string deletion and made another TODO to 
investigate further in conjunction with the other todo.  Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to