kennknowles commented on code in PR #34220:
URL: https://github.com/apache/beam/pull/34220#discussion_r2052577255


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/Pipeline.java:
##########
@@ -147,7 +147,15 @@ public PipelineExecutionException(Throwable cause) {
 
   /** Constructs a pipeline from default {@link PipelineOptions}. */
   public static Pipeline create() {
-    Pipeline pipeline = new Pipeline(PipelineOptionsFactory.create());
+    PipelineOptions options = PipelineOptionsFactory.create();
+    if (options.getRunner() == null) {

Review Comment:
   We don't want this. The runner is intentionally not something the pipeline 
should know about while it is being created.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to