jrmccluskey commented on PR #34700: URL: https://github.com/apache/beam/pull/34700#issuecomment-2821701067
Hey there! I'll try to get a thorough review pass on your PR this afternoon; however, at a quick glance, this seems like a good candidate for inheriting from the new [RemoteModelHandler base class](https://github.com/apache/beam/blob/73739725633f76e1a960e61171e498df1be9012f/sdks/python/apache_beam/ml/inference/base.py#L349) I introduced a few weeks ago. Would you be interested in tweaking your implementation to use this class? It'll streamline your code since it handles the client-side throttling work in the parent class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
