Abacn commented on code in PR #34686:
URL: https://github.com/apache/beam/pull/34686#discussion_r2056144016
##########
sdks/java/io/iceberg/src/test/java/org/apache/beam/sdk/io/iceberg/catalog/BigQueryMetastoreCatalogIT.java:
##########
@@ -62,11 +62,12 @@ public static void deleteDataset() {
@Override
public String tableId() {
- return DATASET + "." + testName.getMethodName() + "_" + SALT;
+ return DATASET + "." + testName.getMethodName() + "_" + salt;
}
@Override
public Catalog createCatalog() {
Review Comment:
since createCatalog is called in setup() which is a non-static method, salt
should also be non-static member
##########
sdks/java/io/iceberg/src/test/java/org/apache/beam/sdk/io/iceberg/catalog/IcebergCatalogBaseIT.java:
##########
@@ -216,9 +222,9 @@ public void cleanUp() throws Exception {
@Rule
public transient Timeout globalTimeout =
- Timeout.seconds(OPTIONS.getRunner().equals(DirectRunner.class) ? 180 :
20 * 60);
+ Timeout.seconds(OPTIONS.getRunner().equals(DirectRunner.class) ? 300 :
20 * 60);
- private static final int NUM_SHARDS = 10;
+ private static final int NUM_SHARDS = 1;
Review Comment:
Will this remove test coverage of sharded case? We can decrease shard /
number of records on direct runner but good to keep parallelism on other
runners (Dataflow)
cc: @ahmedabu98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
