Amar3tto commented on code in PR #34685:
URL: https://github.com/apache/beam/pull/34685#discussion_r2056765847


##########
.github/workflows/beam_PreCommit_Java.yml:
##########
@@ -177,6 +177,9 @@ jobs:
           github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
       - name: Setup environment
         uses: ./.github/actions/setup-environment-action
+        with:
+          python-version: 3.9

Review Comment:
   `python-version: default` should also work (3.9).
   As for upgrading the base ARC image: this is potentially a breaking change 
for many workflows and should be thoroughly tested if we decide to update it.
   I would suggest using `python-version: default` because as I know the basic 
idea of `setup-environment-action` is that if we need to install python, we 
should always explicitly declare it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to