jrmccluskey commented on PR #34719: URL: https://github.com/apache/beam/pull/34719#issuecomment-2828553389
> LGTM. The test failure seems unrelated. > > Looks like the type hints in Anomaly Detection needs to be updated to follow PEP 585 as well. Yeah the failures are the known issue with the gcsio retry test. Updating hints is usually pretty straightforward, the full migration list is at https://peps.python.org/pep-0585/ but for beam it's usually moving to the built-in types (tuple, list, dict, set, frozenset) and then swapping the abstract containers from `typing` to the `collections.abc` equivalents. Under the hood the typing versions are just aliased versions of the collections versions now anyway -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
