JozoVilcek commented on code in PR #34734:
URL: https://github.com/apache/beam/pull/34734#discussion_r2059629967


##########
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java:
##########
@@ -1052,14 +1051,12 @@ protected final void invokeFinishBundle() {
         LOG.debug("Invoking bundle finish callback.");
         bundleFinishedCallback.run();
       }
-    }
-    try {
-      if (previousBundleFinishTime - 
getProcessingTimeService().getCurrentProcessingTime()
-          > maxBundleTimeMills) {

Review Comment:
   Would it be possible to add test ensuring that watermark is always processed 
on finish bundle?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to