tvalentyn commented on code in PR #34695:
URL: https://github.com/apache/beam/pull/34695#discussion_r2060892544


##########
sdks/python/apache_beam/pipeline.py:
##########
@@ -210,6 +207,17 @@ def __init__(
           'Runner %s is not a PipelineRunner object or the '
           'name of a registered runner.' % runner)
 
+    # Runner can oerride the default runner to be used.

Review Comment:
   ```suggestion
       # Runner can override the default pickler to be used.
   ```



##########
sdks/python/apache_beam/pipeline.py:
##########
@@ -210,6 +207,17 @@ def __init__(
           'Runner %s is not a PipelineRunner object or the '
           'name of a registered runner.' % runner)
 
+    # Runner can oerride the default runner to be used.
+    if (self._options.view_as(SetupOptions).pickle_library == 'default' and
+        runner.default_pickle_library_override() is not None):

Review Comment:
   ```suggestion
           runner.default_pickle_library_override()):
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to