twosom commented on code in PR #34560:
URL: https://github.com/apache/beam/pull/34560#discussion_r2061415884
##########
runners/spark/src/main/java/org/apache/beam/runners/spark/SparkTransformOverrides.java:
##########
@@ -50,6 +53,18 @@ public static List<PTransformOverride>
getDefaultOverrides(boolean streaming) {
PTransformOverride.of(
PTransformMatchers.urnEqualTo(PTransformTranslation.SPLITTABLE_PROCESS_KEYED_URN),
new SplittableParDoNaiveBounded.OverrideFactory()));
+ } else {
+ // For streaming pipelines, this override is applied only when the
PTransform has the same URN
Review Comment:
@Abacn
Thanks for the review.
I'll move the comment above the first argument of `PTransformOverride.of`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]