jrmccluskey commented on code in PR #34706:
URL: https://github.com/apache/beam/pull/34706#discussion_r2063772266
##########
sdks/python/apache_beam/typehints/native_type_compatibility_test.py:
##########
@@ -263,6 +263,10 @@ def test_convert_to_beam_type_with_collections_types(self):
collections.defaultdict[str, int],
typehints.Dict[str, int]),
('count', collections.Counter[str, int], typehints.Dict[str, int]),
Review Comment:
This is not genuinely considered a correct use case, no. On the beam side a
`Counter[str, str]` hint would be treated as a `Dict[str, str]` just from
processing, but it wouldn't be satisfied by a proper usage of a counter in a
pipeline and throw an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
