Abacn commented on code in PR #34678:
URL: https://github.com/apache/beam/pull/34678#discussion_r2063794513
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/util/construction/Environments.java:
##########
@@ -219,20 +219,16 @@ public static Environment createDockerEnvironment(String
dockerImageUrl) {
}
private static Environment createExternalEnvironment(String
externalServiceAddress) {
- if (externalServiceAddress.isEmpty()) {
- throw new IllegalArgumentException(
- String.format(
- "External service address must not be empty (set it using
'--environmentOptions=%s=...'?).",
- externalServiceAddressOption));
+ // Create the payload builder. If the address is empty, the payload will
be empty,
+ // acting as a placeholder for late binding (e.g., for LOOPBACK
environment).
Review Comment:
> as a placeholder for late binding
nit: for reference, would be nice to leave a code pointer where later
binding happens (if already figured out).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
