kennknowles commented on code in PR #34657:
URL: https://github.com/apache/beam/pull/34657#discussion_r2064207981
##########
sdks/python/apache_beam/io/gcp/bigquery_file_loads_test.py:
##########
@@ -478,6 +478,44 @@ def test_records_traverse_transform_with_mocks(self):
assert_that(jobs, equal_to([job_reference]), label='CheckJobs')
+ @parameterized.expand([
+ param(compat_version=None),
+ param(compat_version="2.64.0"),
+ ])
+ def test_reshuffle_before_load(self, compat_version):
Review Comment:
If we don't change the old version of the code then we just need basic
testing, not exhaustive. We should expect usage of the flag to be fairly
minimal and diminishing over time, so we shouldn't explode our test suites for
it. I would just add some testing but not necessarily the whole suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
