kennknowles commented on code in PR #34773:
URL: https://github.com/apache/beam/pull/34773#discussion_r2066705673
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/ScanTaskReader.java:
##########
@@ -190,7 +192,8 @@ public Row getCurrent() throws NoSuchElementException {
if (current == null) {
throw new NoSuchElementException();
}
- return IcebergUtils.icebergRecordToBeamRow(source.getSchema(), current);
+ return icebergRecordToBeamRow(
+ icebergSchemaToBeamSchema(source.getSchema()),
checkStateNotNull(current));
Review Comment:
The schema conversion may not be as light as you want it for a per-element
operation. Can you cache the result of `icebergSchemaToBeamSchema`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
