Abacn commented on code in PR #34788:
URL: https://github.com/apache/beam/pull/34788#discussion_r2069005824


##########
sdks/java/io/debezium/build.gradle:
##########
@@ -18,6 +18,18 @@
 import groovy.json.JsonOutput
 
 plugins { id 'org.apache.beam.module' }
+

Review Comment:
   We should generalize this logic and the following and put them into 
BeamModulePlugin, in "applyJavaNature", consider add an optional parameter 
"requireJavaVersion". If set to 17, it will try to get java17Home and 
java21Home.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to