wollowizard commented on PR #34750: URL: https://github.com/apache/beam/pull/34750#issuecomment-2854265732
> Hi, thanks for the fix! > > I added a comment to the bug. Wondering if we can achieve the same improvement with some simplification. If we still do need a static cache, perhaps we can do so in a way benefiting the other types of Datum factories as well. > > Also if we have a static cache cache, I wonder if a unbounded size weak cache would be better. It's less configuration and if the reader/writers are being kept alive anyway the overhead of the cache size seems minimal. https://github.com/google/guava/wiki/cachesexplained#reference-based-eviction thanks @scwhittle I replied to your comment in the bug, thanks for taking a look. regarding your comment about the weak cache, are you referring specifically to weakKeys, weakValues or softValues? My concern is that identity (==) comparison might not work here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
