nielm commented on code in PR #34867:
URL: https://github.com/apache/beam/pull/34867#discussion_r2075944791
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerSchemaTest.java:
##########
@@ -33,22 +33,26 @@ public class SpannerSchemaTest {
public void testSingleTable() throws Exception {
SpannerSchema schema =
SpannerSchema.builder()
- .addColumn("test", "pk", "STRING(48)")
- .addKeyPart("test", "pk", false)
- .addColumn("test", "maxKey", "STRING(MAX)")
- .addColumn("test", "numericVal", "NUMERIC")
- .addColumn("test", "jsonVal", "JSON")
- .addColumn("test", "protoVal", "PROTO<customer.app.TestMessage>")
- .addColumn("test", "enumVal", "ENUM<customer.app.TestEnum>")
- .addColumn("test", "tokens", "TOKENLIST")
- .addColumn("test", "uuidCol", "UUID")
- .addColumn("test", "arrayVal",
"ARRAY<FLOAT32>(vector_length=>256)")
- .addColumn("test", "arrayValue", "ARRAY<FLOAT32>")
+ .addColumn("test", "pk_0", "STRING(48)")
+ .addKeyPart("test", "pk_0", false)
+ .addColumn("test", "maxKey_1", "STRING(MAX)")
+ .addColumn("test", "numericVal_2", "NUMERIC")
+ .addColumn("test", "jsonVal_3", "JSON")
+ .addColumn("test", "protoVal_4", "PROTO<customer.app.TestMessage>")
+ .addColumn("test", "enumVal_5", "ENUM<customer.app.TestEnum>")
+ .addColumn("test", "tokens_6", "TOKENLIST")
+ .addColumn("test", "uuidCol_7", "UUID")
+ .addColumn("test", "arrayVal_8",
"ARRAY<FLOAT32>(vector_length=>256)")
Review Comment:
Cloud Spanner does not support `ARRAY<PROTO>` at all
See: [GoogleSQL data definition language -
Arrays](http://cloud/spanner/docs/reference/standard-sql/data-definition-language#arrays)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
