Abacn commented on code in PR #34440: URL: https://github.com/apache/beam/pull/34440#discussion_r2080730785
########## sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/common/auth/providers/GoogleADCIdTokenProvider.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.io.aws2.common.auth.providers; Review Comment: package name is 9 level nested long. Consider put into .../auth/providers or just under .../auth ? ########## sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/common/auth/providers/StsAssumeRoleWithDynamicWebIdentityCredentialsProvider.java: ########## @@ -0,0 +1,233 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.io.aws2.common.auth.providers; + +import static org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Preconditions.checkState; + +import com.fasterxml.jackson.annotation.JsonSubTypes; +import com.google.auto.value.AutoValue; +import java.util.Optional; +import java.util.UUID; +import java.util.function.Supplier; +import javax.annotation.Nullable; +import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Suppliers; +import software.amazon.awssdk.auth.credentials.AnonymousCredentialsProvider; +import software.amazon.awssdk.auth.credentials.AwsCredentials; +import software.amazon.awssdk.auth.credentials.AwsCredentialsProvider; +import software.amazon.awssdk.regions.Region; +import software.amazon.awssdk.services.sts.StsClient; +import software.amazon.awssdk.services.sts.auth.StsAssumeRoleWithWebIdentityCredentialsProvider; +import software.amazon.awssdk.services.sts.model.AssumeRoleWithWebIdentityRequest; +import software.amazon.awssdk.utils.SdkAutoCloseable; + +/** + * An implementation of AwsCredentialsProvider that periodically sends an {@link + * AssumeRoleWithWebIdentityRequest} to the AWS Security Token Service to maintain short-lived + * sessions to use for authentication. In particular this class will use a {@link + * StsAssumeRoleWithWebIdentityCredentialsProvider} instance as a delegate for the actual + * implementation but it takes care of retrieving a refreshed web id token with every credential's + * resolution request. This is created using builder(). + * + * @see <a + * href="https://docs.aws.amazon.com/STS/latest/APIReference/API_AssumeRoleWithWebIdentity.html";>API + * reference</a> + */ +@AutoValue +@JsonSubTypes({ + @JsonSubTypes.Type( + value = AutoValue_StsAssumeRoleWithDynamicWebIdentityCredentialsProvider.class, + name = "StsAssumeRoleWithDynamicWebIdentityCredentialsProvider") +}) +public abstract class StsAssumeRoleWithDynamicWebIdentityCredentialsProvider Review Comment: `StsAssumeRoleWithWebIdentityCredentialsProvider` is already very long naming. This wrapper provider is even longer... ########## sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/common/auth/providers/GoogleADCIdTokenProvider.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.io.aws2.common.auth.providers; + +import java.io.IOException; +import java.util.Arrays; +import org.apache.beam.vendor.grpc.v1p69p0.com.google.auth.oauth2.GoogleCredentials; +import org.apache.beam.vendor.grpc.v1p69p0.com.google.auth.oauth2.IdTokenCredentials; +import org.apache.beam.vendor.grpc.v1p69p0.com.google.auth.oauth2.IdTokenProvider; +import org.apache.beam.vendor.grpc.v1p69p0.com.google.auth.oauth2.IdTokenProvider.Option; +import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.annotations.VisibleForTesting; + +/** + * A OIDC web identity token provider implementation that uses the application default credentials + * set by the runtime (container, GCE instance, local environment, etc.). + */ +public class GoogleADCIdTokenProvider implements WebIdTokenProvider { Review Comment: This class is not used. Is it user faced? If so, please elaborate javadoc with instructions and use cases -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
