shunping commented on PR #34899: URL: https://github.com/apache/beam/pull/34899#issuecomment-2868941975
> > Thanks for your review. Isn't this contradicting [here](https://github.com/apache/beam/blob/5b862dd510b36ed807414461432749b37eb269b8/sdks/python/apache_beam/pipeline.py#L122), then ? > > Looks like there is inconsistency here. I checked our pipeline proto, and it also says a pipeline is a graph of PTransform. https://github.com/apache/beam/blob/release-2.65/model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/beam_runner_api.proto#L80 My appologies. I closed the PR by mistake. I think we need to modify the comment here instead: https://github.com/apache/beam/blob/5b862dd510b36ed807414461432749b37eb269b8/sdks/python/apache_beam/pipeline.py#L122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
