danielxjd commented on a change in pull request #12786:
URL: https://github.com/apache/beam/pull/12786#discussion_r485264174
##########
File path:
sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java
##########
@@ -299,9 +344,14 @@ public ReadFiles withSplit() {
public PCollection<GenericRecord> expand(PCollection<FileIO.ReadableFile>
input) {
checkNotNull(getSchema(), "Schema can not be null");
if (isSplittable()) {
+ if (getProjection() == null) {
Review comment:
Changed.
##########
File path:
sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java
##########
@@ -279,6 +312,10 @@ public void populateDisplayData(DisplayData.Builder
builder) {
abstract Builder setAvroDataModel(GenericData model);
+ abstract Builder setProjectionEncoder(Schema schema);
+
+ abstract Builder setProjection(Schema schema);
Review comment:
Changed
##########
File path:
sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java
##########
@@ -269,6 +298,10 @@ public void populateDisplayData(DisplayData.Builder
builder) {
abstract @Nullable GenericData getAvroDataModel();
+ abstract @Nullable Schema getProjectionEncoder();
+
+ abstract @Nullable Schema getProjection();
Review comment:
Changed.
##########
File path:
sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java
##########
@@ -209,6 +223,10 @@ public static ReadFiles readFiles(Schema schema) {
abstract Builder setSchema(Schema schema);
+ abstract Builder setProjectionEncoder(Schema schema);
+
+ abstract Builder setProjection(Schema schema);
Review comment:
Changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
