aaltay commented on a change in pull request #12789:
URL: https://github.com/apache/beam/pull/12789#discussion_r485271282
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##########
@@ -923,8 +923,9 @@ def job_id_for_name(self, job_name):
pageToken=token)
response = self._client.projects_locations_jobs.List(request)
for job in response.jobs:
- if (job.name == job_name and job.currentState ==
- dataflow.Job.CurrentStateValueValuesEnum.JOB_STATE_RUNNING):
+ if (job.name == job_name and job.currentState in
Review comment:
On a second thought, I do not know if we will break some users if we
rename this. I do not think so but it will still a breaking change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
