kennknowles commented on PR #34919: URL: https://github.com/apache/beam/pull/34919#issuecomment-2891674027
Thanks for bearing with me and paying close attention to this! I know the diffs are not particularly helpful in seeing what the real change is. I do think the positive delta is almost all boilerplate and things are shrinking in spirit and cyclomatic complexity is reducing. Just a couple more and it'll be more like straight line code based on the URN, which should lend itself to (1) pulling out more shared and _meaningful_ abstractions and (2) optimizing and further simplifying specific paths by finding more stuff that was in there just because it was hard to tell which operation we were performing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
