tvalentyn commented on code in PR #35003:
URL: https://github.com/apache/beam/pull/35003#discussion_r2100705776
##########
sdks/python/setup.py:
##########
@@ -354,7 +354,8 @@ def get_portability_package_data():
'fastavro>=0.23.6,<2',
'fasteners>=0.3,<1.0',
# TODO(https://github.com/grpc/grpc/issues/37710): Unpin grpc
-
'grpcio>=1.33.1,<2,!=1.48.0,!=1.59.*,!=1.60.*,!=1.61.*,!=1.62.0,!=1.62.1,<1.66.0',
# pylint: disable=line-too-long
+
'grpcio>=1.33.1,<2,!=1.48.0,!=1.59.*,!=1.60.*,!=1.61.*,!=1.62.0,!=1.62.1,<1.66.0;
python_version <= "3.12"', # pylint: disable=line-too-long
+ 'grpcio>=1.67.0; python_version >= "3.13"',
Review Comment:
> Do we know if that environment variable has any impact for GRPC versions <
1.66.0? Conditional environmental variables are not a thing docker likes to do.
We can reach out to grpc people; we do control the version of grpc in our
containers, so it doesn't need to be conditional.
RUN python -c "<some command with a condition>" || export <somevar> might
also work if we want to enable it for 3.13 only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
