derrickaw commented on code in PR #34782:
URL: https://github.com/apache/beam/pull/34782#discussion_r2100999388


##########
sdks/java/extensions/schemaio-expansion-service/build.gradle:
##########
@@ -58,6 +58,7 @@ dependencies {
     permitUnusedDeclared 'com.google.cloud:alloydb-jdbc-connector:1.2.0'
     testImplementation library.java.junit
     testImplementation library.java.mockito_core
+    runtimeOnly ("org.xerial:sqlite-jdbc:3.49.1.0")

Review Comment:
   1. It contains the driver for connecting to the DB.
   2. My understanding is that testImplementation is for tests inside that the 
schemaio-expansion-service module.  We need the runtimeOnly so that its 
packaged in the jar for use later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to