robertwb commented on code in PR #34764:
URL: https://github.com/apache/beam/pull/34764#discussion_r2104994460
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/util/WindowedValue.java:
##########
@@ -61,40 +62,65 @@ public abstract class WindowedValue<T> {
/** Returns a {@code WindowedValue} with the given value, timestamp, and
windows. */
public static <T> WindowedValue<T> of(
- T value, Instant timestamp, Collection<? extends BoundedWindow> windows,
PaneInfo pane) {
+ T value,
+ Instant timestamp,
+ Collection<? extends BoundedWindow> windows,
+ PaneInfo pane,
+ @Nullable ElementMetadata elementMetadata) {
checkArgument(pane != null, "WindowedValue requires PaneInfo, but it was
null");
checkArgument(windows.size() > 0, "WindowedValue requires windows, but
there were none");
Review Comment:
Perhaps also validate here that elementMetadata is null if and only if
PaneInfo expects metadata?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
