robertwb commented on code in PR #35049:
URL: https://github.com/apache/beam/pull/35049#discussion_r2110479675
##########
sdks/python/apache_beam/metrics/cells.py:
##########
@@ -137,7 +138,11 @@ def update(self, value):
# directly by circumventing the GIL.
self.value += ivalue
else:
- with self._lock:
+ # If a container lock is provided, use it. Otherwise, use cell's own
lock.
Review Comment:
Are cells ever not managed by a metrics container?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
