jrmccluskey commented on code in PR #35022:
URL: https://github.com/apache/beam/pull/35022#discussion_r2112311234
##########
sdks/python/apache_beam/yaml/integration_tests.py:
##########
@@ -359,7 +489,10 @@ def replace_recursive(spec, vars):
}
elif isinstance(spec, list):
return [replace_recursive(value, vars) for value in spec]
- elif isinstance(spec, str) and '{' in spec and '{\n' not in spec:
+ # TODO(derrickaw): Consider checking for callable in the if branch above
+ # instead of checking lambda here.
Review Comment:
Nit: consider linking to a GitHub Issue rather than a username for ToDos.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
