aaltay commented on a change in pull request #12756:
URL: https://github.com/apache/beam/pull/12756#discussion_r485860554
##########
File path: sdks/python/setup.py
##########
@@ -165,6 +165,7 @@ def get_version():
'requests>=2.24.0,<3.0.0',
'typing>=3.7.0,<3.8.0; python_full_version < "3.5.3"',
'typing-extensions>=3.7.0,<3.8.0',
+ 'mmh3>=2.5.1,<2.5.2',
Review comment:
It is better to avoid adding a new dependency if possible especially a
one with platform specific differences. If we need to add it, it is better to
make it optional similar to snappy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
