Abacn commented on code in PR #35076: URL: https://github.com/apache/beam/pull/35076#discussion_r2114742774
########## sdks/java/io/google-cloud-platform/src/main/proto/change_stream.proto: ########## @@ -0,0 +1,466 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +syntax = "proto3"; Review Comment: This is not supported. Beam gcp-io module as a client for GCP service isn't a place to add proto. I see this is copy-pasted from internal code (not even apache 2 licensed). Protos from same path are released externally as java library: https://mvnrepository.com/artifact/com.google.api.grpc/proto-google-cloud-spanner-v1/6.94.0 please add change_stream.proto to external proto-google-cloud-spanner-v1 release if it is needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
