mxm commented on a change in pull request #12776:
URL: https://github.com/apache/beam/pull/12776#discussion_r485910049
##########
File path: runners/flink/build.gradle
##########
@@ -0,0 +1,32 @@
+/*
Review comment:
Is this merely an optimization to avoid running Spotless for each Flink
version? If so, probably not worth splitting the config as the overhead for
running spotless on the Flink sources multiple times is very low.
##########
File path: runners/flink/build.gradle
##########
@@ -0,0 +1,32 @@
+/*
Review comment:
Besides, I think the spotless task should be part of the actual Flink
project, e.g. `runners/flink/1.10` (not `runners/flink`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
