scwhittle commented on code in PR #35110:
URL: https://github.com/apache/beam/pull/35110#discussion_r2121224209
##########
sdks/python/apache_beam/io/textio.py:
##########
@@ -1056,6 +1056,8 @@ def WriteToJson(
kwargs['num_shards'] = num_shards
if file_naming is not None:
kwargs['file_naming'] = file_naming
+ if 'max_writers_per_bundle' not in kwargs:
+ kwargs['max_writers_per_bundle'] = 0
Review Comment:
Out-of-the-box bad performance isn't good either. I would recommend
changing the default to unspecified (similar to # of shards in java) and say
that the runner will pick an appropriate value. And we can use the existing
default for other runners and batch dataflow pipelines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
