parveensania commented on code in PR #34148:
URL: https://github.com/apache/beam/pull/34148#discussion_r2124088516


##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/harness/FanOutStreamingEngineWorkerHarness.java:
##########
@@ -271,7 +280,10 @@ private void consumeWorkerMetadata(WindmillEndpoints 
windmillEndpoints) {
     synchronized (metadataLock) {
       // Only process versions greater than what we currently have to prevent 
double processing of
       // metadata. workerMetadataConsumer is single-threaded so we maintain 
ordering.
-      if (windmillEndpoints.version() > pendingMetadataVersion) {
+      // But in case the endpoint type in worker metadata is different from 
the active endpoint
+      // type, also process those endpoints
+      if (windmillEndpoints.version() > pendingMetadataVersion
+          || windmillEndpoints.endpointType() != activeEndpointType) {

Review Comment:
   Added the condition



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to