TanuSharma2511 commented on code in PR #35017:
URL: https://github.com/apache/beam/pull/35017#discussion_r2125859462
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/firestore/FirestoreV1.java:
##########
@@ -1528,10 +1594,33 @@ public static final class Builder
BatchWriteWithDeadLetterQueue,
BatchWriteWithDeadLetterQueue.Builder> {
+ private @Nullable String projectId;
+ private @Nullable String databaseId;
+
private Builder() {
super();
}
+ public Builder setProjectId(@Nullable String projectId) {
+ this.projectId = projectId;
+ return this;
+ }
+
+ public Builder setDatabaseId(@Nullable String databaseId) {
+ this.databaseId = databaseId;
+ return this;
+ }
+
+ @VisibleForTesting
+ public @Nullable String getProjectId() {
+ return this.projectId;
+ }
+
+ @VisibleForTesting
+ public @Nullable String getDatabaseId() {
+ return this.databaseId;
+ }
Review Comment:
Done. I think getDatabaseId and getDatabaseId can be private as these are
used only for test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
