baeminbo commented on PR #35063: URL: https://github.com/apache/beam/pull/35063#issuecomment-2943952833
> Thanks for the fix @baeminbo! > > This is the first time we are making an actual change to the cloudpickle library. As we diverge from the official repo I think we should be a bit more careful to validate our changes. > > I suggest we: > > 1. Fork the official cloudpickle repo and create a PR with this fix (in the official repo) > 2. Run the official cloudpickle repo test in suite to verify that it doesn't break any existing unit tests > 3. Add an integration test that reproduces the GroupIntoBatches bug that is being fixed by this PR > 4. Run Python postcommit > > I can help with this if you do not have the bandwidth. Thanks for testing the fix on the official repository. I'll make a PR for the official cloudpickle repo. How can I add an integration test? Is there any example I can refer to? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
