hjtran commented on code in PR #35164:
URL: https://github.com/apache/beam/pull/35164#discussion_r2131398614


##########
sdks/python/apache_beam/typehints/typehints.py:
##########
@@ -1563,6 +1563,8 @@ def get_yielded_type(type_hint):
   Raises:
     ValueError if not iterable.
   """
+  if isinstance(type_hint, TypeVariable):
+    raise ValueError('%s is not iterable' % type_hint)

Review Comment:
   Well, thinking about it more, both seem possibly incorrect. We don't know 
it's not iterable and if it isn't iterable, then it shouldn't have a yield type 
of Any.
   
   Nevertheless, I'll change it to Any to be consistent with `strip_iterable`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to