LEEKYE commented on code in PR #35120:
URL: https://github.com/apache/beam/pull/35120#discussion_r2132877217
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptions.java:
##########
@@ -424,4 +424,16 @@ public String create(PipelineOptions options) {
return String.format("%s/%s", info.getName(),
info.getVersion()).replace(" ", "_");
}
}
+
+ /**
+ * The time limit (minute) that an SDK worker allows for a PTransform
operation before signaling
+ * the runner harness to restart the SDK worker.
+ */
+ @Default.Integer(Integer.MAX_VALUE)
Review Comment:
> It sounds like this better fits in
https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/options/SdkHarnessOptions.java?
>
> Large number is still finite number technically (here it is 4,000 y).
Things will get a little bit more complicated in Python as tehre isn't
Integer.MAX_VALUE for Python native int
>
> Consider set default to 0 and handle it in implementation?
In fact, what matters here is if the default timeout duration is big enough,
it only acts as a valid input that keeps the pipeline running in case there is
not one. In python, we can just set a big number like 100000 as the default
number. However, it might be another story if you have code style concerns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
