Abacn commented on code in PR #35120:
URL: https://github.com/apache/beam/pull/35120#discussion_r2136301109
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ExecutionStateSampler.java:
##########
@@ -65,6 +66,7 @@ public class ExecutionStateSampler {
private static final Logger LOG =
LoggerFactory.getLogger(ExecutionStateSampler.class);
private static final int DEFAULT_SAMPLING_PERIOD_MS = 200;
Review Comment:
It's pipeline option, passed from command line options so primitives are
usually used. Pipeline option can have non-primitive type but one then need to
create a Factory class to parse the passed in parameters and do the reverse
Joda time is a big tech debt: #19215. But yes we can use java.time for new
code if it does not involve Beam's timestamped value and coders
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
