Abacn commented on PR #34738: URL: https://github.com/apache/beam/pull/34738#issuecomment-2956905319
> Could you add some context on why we need this change/the Dataflow side changes enabling it? It generally seems fine, but I'm not sure why we need it Thanks. Internal tracker is b/404336511. Basically - Dataflow backend does not yet support returning BoundedTrie metrics - When it supports, it will trigger a ClassCastException at https://github.com/apache/beam/blob/df54bf439b28b23c3380b913811633fd8678c403/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowMetrics.java#L212 because the returned type isn't BoundedTrie. As a result a "boundedTrie" field is added in Dataflow v1beta3 proto, and properly handled by this PR (tested) "trie" will remain empty and unused. So the Dataflow side rollout won't affect Beam 2.65 and earlier versions as we had similar issue (#32622) on Beam 2.58.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
