damccorm opened a new pull request, #35219: URL: https://github.com/apache/beam/pull/35219
As part of https://github.com/apache/beam/issues/34549 to enable Prism by default, this identifies tests which are for behaviors which either: 1) Are not testable on prism. Examples include tests which use mocks which need to be referenced in the same python process (which doesn't work since Prism is portable), tests which access attributes which are only present on the FnApiRunner, or tests which require behaviors only guaranteed by the FnApiRunner 2) Are minor behavior differences which may or may not require a fix, but should not require holding back making prism the default, and which cannot be systematically checked when [walking the pipeline](https://github.com/apache/beam/blob/df54bf439b28b23c3380b913811633fd8678c403/sdks/python/apache_beam/runners/direct/direct_runner.py#L115). Many more conditions can be checked, and are in my WIP pr - https://github.com/apache/beam/pull/34612 For any of these, this PR pins to the FnApiRunner (currently the default runner) so that when we transition to Prism as the default, these won't break. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
