ahmedabu98 commented on code in PR #35223: URL: https://github.com/apache/beam/pull/35223#discussion_r2138245665
########## sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/catalog/Catalog.java: ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.extensions.sql.meta.catalog; + +import java.util.Map; +import org.apache.beam.sdk.extensions.sql.meta.store.MetaStore; + +public interface Catalog { Review Comment: One thing to note though -- in other places, DDL methods are directly accessible via the Catalog (even if they may be redirected to an internal metastore/catalog). The current PR expects us to drill down an extra step (i.e. `.metaStore()` to access such methods). I'm slightly leaning towards keeping it this way, but am also open to surfacing all those methods to the Catalog interface. For us, it means the following methods: - createTable() - dropTable() - getTable() - getTables() Note that our MetaStore is missing the following: - createNamespace() - listNamespaces() - dropNamespace() - alterTable() - renameTable() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
