claudevdm commented on code in PR #35215: URL: https://github.com/apache/beam/pull/35215#discussion_r2138630160
########## sdks/python/apache_beam/ml/rag/ingestion/alloydb.py: ########## @@ -14,39 +14,31 @@ # See the License for the specific language governing permissions and # limitations under the License. -import json -import logging from dataclasses import dataclass -from dataclasses import field from typing import Any -from typing import Callable from typing import Dict from typing import List -from typing import Literal -from typing import NamedTuple from typing import Optional -from typing import Type -from typing import Union -import apache_beam as beam -from apache_beam.coders import registry -from apache_beam.coders.row_coder import RowCoder -from apache_beam.io.jdbc import WriteToJdbc -from apache_beam.ml.rag.ingestion.base import VectorDatabaseWriteConfig -from apache_beam.ml.rag.types import Chunk - -_LOGGER = logging.getLogger(__name__) +from apache_beam.ml.rag.ingestion.jdbc_common import ConnectionConfig +from apache_beam.ml.rag.ingestion.jdbc_common import WriteConfig +from apache_beam.ml.rag.ingestion.postgres import ColumnSpecsBuilder +from apache_beam.ml.rag.ingestion.postgres import PostgresVectorWriterConfig +from apache_beam.ml.rag.ingestion.postgres_common import ColumnSpec +from apache_beam.ml.rag.ingestion.postgres_common import ConflictResolution @dataclass class AlloyDBLanguageConnectorConfig: Review Comment: Added github issue + changes.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
