Abacn commented on PR #35252: URL: https://github.com/apache/beam/pull/35252#issuecomment-2970561160
ah, this one actually triggers a spotBug check: ``` new org.apache.beam.fn.harness.status.BeamFnStatusClient(Endpoints$ApiServiceDescriptor, Function, ProcessBundleHandler$BundleProcessorCache, PipelineOptions, Cache) invokes Thread.start() -- | Bug type SC_START_IN_CTOR (click for details)In class org.apache.beam.fn.harness.status.BeamFnStatusClientIn method new org.apache.beam.fn.harness.status.BeamFnStatusClient(Endpoints$ApiServiceDescriptor, Function, ProcessBundleHandler$BundleProcessorCache, PipelineOptions, Cache)Called method Thread.start()At BeamFnStatusClient.java:[line 76] new org.apache.beam.fn.harness.status.BeamFnStatusClient(Endpoints$ApiServiceDescriptor, Function, ProcessBundleHandler$BundleProcessorCache, PipelineOptions, Cache) invokes Thread.start() [Bug type SC_START_IN_CTOR (click for details)](https://github.com/apache/beam/pull/35252#SC_START_IN_CTOR) In class org.apache.beam.fn.harness.status.BeamFnStatusClient In method new org.apache.beam.fn.harness.status.BeamFnStatusClient(Endpoints$ApiServiceDescriptor, Function, ProcessBundleHandler$BundleProcessorCache, PipelineOptions, Cache) Called method Thread.start() At BeamFnStatusClient.java:[line 76] SC_START_IN_CTOR: Constructor invokes Thread.start() The constructor starts a thread. This is likely to be wrong if the class is ever extended/subclassed, since the thread will be started before the subclass constructor is started. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
