razvanculea commented on code in PR #35137:
URL: https://github.com/apache/beam/pull/35137#discussion_r2145558952
##########
sdks/python/apache_beam/io/iobase.py:
##########
@@ -1127,47 +1168,183 @@ def __init__(self, sink: Sink) -> None:
self.sink = sink
def expand(self, pcoll):
Review Comment:
@shunping , i don't have better naming for
[finalize_windowed_write](https://github.com/apache/beam/pull/35137#discussion_r2143457336)
, this is doing the necessary finalization operation in case of writing per
window in streaming, as finalize_write is doing for GlobalWindow in batch
I liked more this name than finalize_write_per_window() , but i don't know
which would be best for someone discovering it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
