damccorm commented on PR #35289: URL: https://github.com/apache/beam/pull/35289#issuecomment-2976733593
Thanks - this looks like a good change, but I'd like to get a little more test coverage on the PR. I think https://github.com/apache/beam/blob/e51461a22617ef868e572709927ab48300e44c07/sdks/python/apache_beam/examples/wordcount_it_test.py#L93 should test this and run as part of https://github.com/apache/beam/blob/master/.github/workflows/beam_PostCommit_Python_ValidatesContainer_Dataflow.yml . Could you trigger that workflow by modifying https://github.com/apache/beam/blob/master/.github/trigger_files/beam_PostCommit_Python_ValidatesContainer_Dataflow.json and pushing it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
