kennknowles commented on code in PR #34902:
URL: https://github.com/apache/beam/pull/34902#discussion_r2151011102
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/util/construction/SplittableParDoNaiveBounded.java:
##########
@@ -524,22 +526,15 @@ public String timerId(DoFn<InputT, OutputT> doFn) {
public OutputReceiver<OutputT> outputReceiver(DoFn<InputT, OutputT>
doFn) {
return new OutputReceiver<OutputT>() {
@Override
- public void output(OutputT output) {
- outerContext.output(output);
- }
-
- @Override
- public void outputWithTimestamp(OutputT output, Instant timestamp) {
- outerContext.outputWithTimestamp(output, timestamp);
- }
-
- @Override
- public void outputWindowedValue(
- OutputT output,
- Instant timestamp,
- Collection<? extends BoundedWindow> windows,
- PaneInfo paneInfo) {
- outerContext.outputWindowedValue(output, timestamp, windows,
paneInfo);
+ public OutputBuilder<OutputT> builder(OutputT value) {
+ return WindowedValue.<OutputT>builder(
+ outputBuilder ->
+ outerContext.outputWindowedValue(
Review Comment:
OK now I've gotten far enough that I see how I can reverse the layering so
the ProcessContext in all the FnApiDoFnRunners and SimpleDoFnRunner can/should
use the builder properly. To be completed... doing FnApiDoFnRunner last because
it is the most work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
